Submission Details
Severity:
EPOCH_DURATION should used instead of "1 weeks"
Summary
EPOCH_DURATION should used instead of "1 weeks"
Vulnerability Details
https://github.com/Cyfrin/2024-08-fjord/blob/main/src/FjordPoints.sol#L245
uint256 public constant EPOCH_DURATION = 1 weeks;
EPOCH_DURATION is "1 weeks" in FjordPoints.sol, maybe one day, code will change to another value, such as 4 weeks, then function distributePoints() will action abnomally.
Impact
if EPOCH_DURATION is not "1 weeks", function distributePoints() will action abnomally.
Tools Used
manually reviewed
Recommendations
function distributePoints() public {
if (block.timestamp < lastDistribution + EPOCH_DURATION) {
return;
}
if (totalStaked == 0) {
return;
}
uint256 epochsPending = (block.timestamp - lastDistribution) / EPOCH_DURATION;
pointsPerToken =
pointsPerToken.add(epochsPending * (pointsPerEpoch.mul(PRECISION_18).div(totalStaked)));
totalPoints = totalPoints.add(pointsPerEpoch * epochsPending);
lastDistribution = lastDistribution + (epochsPending * EPOCH_DURATION);
emit PointsDistributed(pointsPerEpoch, pointsPerToken);
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.