Submission Details
Severity:
Use internal functions in modifiers to save gas
Summary
Using internal functions in modifiers for checks saves gas, because if you don't the compiler inlines the entire modifier body everytime the modifier is used which costs gas.
Vulnerability Details
Impact
Tools Used
Manual Review
Recommendations
Move modifier body into an internal function, i.e Instead of :
modifier onlyKittyPool() {
require(msg.sender == pool, KittyCoin__OnlyKittyPoolCanMintOrBurn());
_;
}
Do this instead:
function _onlyKittyPool() internal {
require(msg.sender == pool, KittyCoin__OnlyKittyPoolCanMintOrBurn());
}
modifier onlyKittyPool() {
_onlyKittyPool();
_;
}
Rewards breakdown
nSLOC
224This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.