Submission Details
Severity:
Deposits Not Yielding Interest
Summary
The depawsitMeowllateral function calls executeDepawsit in KittyVault, but there is no subsequent action to supply the deposited collateral to Aave for earning yield.
Vulnerability Details
function depawsitMeowllateral(address _token, uint256 _ameownt) external tokenExists(_token) {
IKittyVault(tokenToVault[_token]).executeDepawsit(msg.sender, _ameownt);
}
Impact
Deposited funds are not utilized to generate interest, potentially leading to user dissatisfaction and loss of intended protocol functionality.
Tools Used
manual review
Recommendations
Include a call to supply the deposited collateral to Aave immediately after executing the deposit. The updated function could be:
function depawsitMeowllateral(address _token, uint256 _ameownt) external tokenExists(_token) {
IKittyVault(tokenToVault[_token]).executeDepawsit(msg.sender, _ameownt);
IKittyVault(tokenToVault[_token]).purrrCollateralToAave(_ameownt);
}
Rewards breakdown
nSLOC
224This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.