Submission Details
Severity:
kittyVault::getUserVaultMeowllateralInEuros ignores return value by (,euroPriceFeedAns,,,) = i_euroPriceFeed.latestRoundData(), resulting is computation having no effect.
Summary
kittyVault::getUserVaultMeowllateralInEuros function gets user's collateral for this vault in euros. kittyVault::getUserVaultMeowllateralInEuros function ignores return value by (,euroPriceFeedAns,,,) = i_euroPriceFeed.latestRoundData() which results to computation with no effects. This makes user's collateral for this vault in euros not possible.
Vulnerability Details
function getUserVaultMeowllateralInEuros(address _user) external view returns (uint256) {
@> (, int256 collateralToUsdPrice, , , ) = i_priceFeed.latestRoundData();
@> (, int256 euroPriceFeedAns, , ,) = i_euroPriceFeed.latestRoundData();
uint256 collateralAns = getUserMeowllateral(_user).mulDiv(uint256(collateralToUsdPrice) * EXTRA_DECIMALS, PRECISION);
return collateralAns.mulDiv(uint256(euroPriceFeedAns) * EXTRA_DECIMALS, PRECISION);
}
Impact
This makes user's collateral for this vault in euros not possible.
Tools Used
Manual Review
Recommendations
Ensure that the return values of the kittyVault::getUserVaultMeowllateralInEuros function are used.
Rewards breakdown
nSLOC
224This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.