Submission Details
Severity:
`KittyPool:burnKittyCoin` always burns the msg.sender tokens
Summary
In the function KittyPool:burnKittyCoin we are always burning the msg.sender tokens rather than the address `_onBehalfOf`.
Vulnerability Details
function burnKittyCoin(address _onBehalfOf, uint256 _ameownt) external {
kittyCoinMeownted[_onBehalfOf] -= _ameownt;
>> i_kittyCoin.burn(msg.sender, _ameownt);
}
Impact
We will always burn the `msg.sender` tokens. Resulting in unexpected behaviour and lose in users trust in the protocol.
Tools Used
Manual review.
Recommendations
Change the following lines to prevent always burning msg.sender tokens.
- i_kittyCoin.burn(msg.sender, _ameownt);
+ i_kittyCoin.burn(_onBehalfOf, _ameownt);
Rewards breakdown
nSLOC
224This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.