Submission Details
Severity:
Missing check for access control for changing owner
Vulnerability Details
As a owner, maybe we want to change the ownership. But in this code , there is no action for checking the msg.sender. whether msg.sender is the owner?
function changeOwner(address _newOwner) public {
// @audit-high missing access control to change owner
owner = _newOwner;
}
Impact
Every users can change the owner whenever they want
Tools Used
Manual review
Recommendations
Add the checking action to ensure only the owner can change the ownership.
function changeOwner(address _newOwner) public {
+ require(msg.sender == owner, "msg.sender isn't owner!");
owner = _newOwner;
}
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
Anyone can change owner
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.