Mystery Box

Summary

The value assigned to the "Silver Coin" reward in the openBox function is inconsistent with its initial value in the constructor, leading to potential discrepancies in user expectations and actual rewards.

Vulnerability Details

In the constructor, the "Silver Coin" is initialized with a value of 0.25 ether. In the openBox function, the "Silver Coin" is assigned a value of 0.5 ether. This inconsistency can lead to confusion and incorrect reward distribution.

Impact

Users may receive a different value than expected when opening a box, leading to potential disputes or dissatisfaction.

Steps to Exploit

1. A user opens a mystery box expecting a "Silver Coin" valued at 0.25 ether.

2. The user receives a "Silver Coin" with a value of 0.5 ether instead, causing a discrepancy in the contract's balance.

Tools Used

Manual Review

Recommendations

Ensure consistency in reward values by aligning the value of the "Silver Coin" in the openBox function with its initialization value in the constructor.