Submission Details
Severity:
Unhandled zero balances in function `claimAllReward`
Summary
Unhandled zero balances in function claimAllReward, wich inefficient to loop over rewards with 0 value.
Vulnerability Details
If any of the rewards in function claimAllReward where rewardsOwned[msg.sender] have a value of 0, these rewards are still added to totalValue.
Impact
Although require(totalValue > 0, "No rewards to claim"); prevents claiming when the total value is 0, it's inefficient to loop over rewards with 0 value. Also, the loop should skip rewards with a 0 balance.
Tools Used
Manual review.
Recommendations
Add a condition to skip rewards with 0 value during the accumulation process:
for (uint256 i = 0; i < rewardsOwned[msg.sender].length; i++) {
if (rewardsOwned[msg.sender][i].value > 0) {
totalValue += rewardsOwned[msg.sender][i].value;
}
}
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.