Mystery Box

First Flight #25
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Valid

MysteryBox::addReward() function doesn't add a reward to the actual prize pool

Summary

MysteryBox::addReward() doesn't add a reward to the pool as MysteryBox::openBox() has fixed probability values so the probability of getting the newly added reward is 0

Vulnerability Details

MysteryBox::addReward() doesn't add a reward to MysteryBox::openBox() so won't add it to the prize pool

Impact

Rewards are fixed so new rewards can't be added to the protocol

Tools Used

Manual Review

Recommendations

  • Allow MysteryBox::openBox() to work with non fixed probabilities

Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

addReward won't have any effect on openBox

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!