Submission Details
Severity:
claimAllRewards() does not follow CEI, thus suffer of reentrancy issue
Summary
The function `claimAllRewards` suffers from reentrancy, meaning a malicious smart contract can reenter the functions and withdraw all funds.
Vulnerability Details
a user deploys a malicious smart contract that will buy a box and open it until it gets one with a prize
User call malicious smart contract to call
claimAllRewards()The `fallback()` function of the malicious smart contract call
claimAllRewards()until there is no more fund
Impact
Withdraw all funds from the protocol
Recommendations
Follow CEI :
function claimAllRewards() public {
uint256 totalValue = 0;
for (uint256 i = 0; i < rewardsOwned[msg.sender].length; i++) {
totalValue += rewardsOwned[msg.sender][i].value;
}
require(totalValue > 0, "No rewards to claim");
+ delete rewardsOwned[msg.sender];
(bool success,) = payable(msg.sender).call{value: totalValue}("");
require(success, "Transfer failed");
- delete rewardsOwned[msg.sender];
}
Updates
Appeal created
inallhonesty 9 months ago
Submission Judgement Published Assigned finding tags:
`claimAllRewards` reentrancy
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.