Mystery Box
First Flight #25
Beginner FriendlyFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: high
Invalid

It might be necessary to reconsider the Protocol regarding the withdrawal of funds by users.

eth0x

In the Protocol are rewards with their value in eth. Functions for withdraw rewards are

claimAllRewards, claimSingleReward and transferReward

From my obserwation it is necessary to determine who should send funds to the protocol and how they should do it. To ensure that the rewards are backed by Ethereum. Because at this moment it is not clear and not implemented in protocol.

In the Protocol's constructor is:

...
rewardPool.push(Reward("Gold Coin", 0.5 ether));
rewardPool.push(Reward("Silver Coin", 0.25 ether));
rewardPool.push(Reward("Bronze Coin", 0.1 ether));
rewardPool.push(Reward("Coal", 0 ether));
...

However, these values have a virtual cost, as the balance in the MysteryBox contract after initialization is only 0.1 ETH instead of 0.85 ETH.

Specifically, you should consider clarifying the reward collection process: Define how rewards are collected and who is responsible for sending them to the protocol.

Updates

Appeal created

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic
eth0x Submitter
about 1 year ago
inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Too generic

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!