Submission Details
Severity:
Gas Costs for claimAllRewards()
Summary
The claimAllRewards function iterates through all rewards in rewardsOwned[msg.sender], which can be expensive in terms of gas fees if a user has many rewards.
Vulnerability Details
function claimAllRewards() public {
uint256 totalValue = 0;
for (uint256 i = 0; i < rewardsOwned[msg.sender].length; i++) {
totalValue += rewardsOwned[msg.sender][i].value;
}
}
Impact
Gas costs increase linearly with the number of rewards, which could make the function impractical for users with many rewards.
Tools Used
Recommendations
Consider breaking up the reward claiming process into smaller steps or allowing users to claim rewards incrementally to avoid excessive gas fees.
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
Gas Limit Exhaustion in `claimAllRewards` Function
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.