Submission Details
Severity:
claimAllRewards - Reentrancy
Summary/ Vulnerability Details/ Impact :
The Ether transfer (Interaction) is performed before the contract's internal state (Effects) is updated. This means that if a reentrancy attack is performed via the user's fallback function or receive function, the user could potentially call claimAllRewards again before their rewards are removed, allowing them to claim the same rewards multiple times.
Tools Used :
Slither, Wake, Foundry
Recommendations :
To respect the CEI model, the order of Effects and Interactions must be reversed:
function claimAllRewards() public {
uint256 totalValue = 0;
for (uint256 i = 0; i < rewardsOwned[msg.sender].length; i++) {
totalValue += rewardsOwned[msg.sender][i].value;
}
require(totalValue > 0, "No rewards to claim");
// Effects: Mise à jour de l'état AVANT l'interaction
delete rewardsOwned[msg.sender];
// Interactions: Transfert d'Ether APRÈS la mise à jour de l'état
(bool success,) = payable(msg.sender).call{value: totalValue}("");
require(success, "Transfer failed");
}
Updates
Appeal created
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`claimAllRewards` reentrancy
dayeneris1
about 1 year ago
inallhonesty
about 1 year ago
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
`claimAllRewards` reentrancy
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.