Mystery Box

Summary

When the owner adds new rewards using the MysteryBox::addReward function, the rewards available to players don’t change because the rewards are hardcoded in the MysteryBox::openBox function. Additionally, the hardcoded rewards in the MysteryBox::openBox function don’t match the rewards initialized in the rewardPool within the constructor (the same reward names have different values).

Impact

Players will receive the same rewards even if the owner adds new ones.

If a player calls the MysteryBox::getRewardPool function to check available rewards, they’ll see incorrect values.

Recommendations

Update the MysteryBox::openBox function to pull rewards from the rewardPool.