Submission Details
Severity:
`MysteryBox.sol::changeOwner` missing the control access and validation check on the new owner
Relevant GitHub Links
https://github.com/Cyfrin/2024-09-mystery-box/blob/main/src/MysteryBox.sol#L111
Summary
The `MysteryBox.sol::changeOwner` function is set to public giving the possibility to anyone to change the `owner` with any new address (included `address(0)`)
Vulnerability Details
The `MysteryBox.sol::changeOwner` function is set to public without any modifier to limit the access and there is no validation check of the input provided by the caller
Impact
All the privileges of the owner can be assigned by anyone to `address(0)` making the protocol unusable.
Tools Used
Manual review, Foundry
Recommendations
- function changeOwner(address _newOwner) public {
- owner = _newOwner;
- }
+ function changeOwner(address _newOwner) public {
+ require (msg.sender == owner, "You are not the owner")
+ require (_newOwner!= address(0), " new owner is address(0)"
+ }
Updates
Appeal created
inallhonesty 8 months ago
Submission Judgement Published Assigned finding tags:
Anyone can change owner
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.