Submission Details
Severity:
Wrong reward data in `openBox` function
Summary
In our rewardPoolarray we have following box properties
rewardPool.push(Reward("Gold Coin", 0.5 ether));
rewardPool.push(Reward("Silver Coin", 0.25 ether));
rewardPool.push(Reward("Bronze Coin", 0.1 ether));
rewardPool.push(Reward("Coal", 0 ether));
But in openBoxfunction we have following code:
- rewardsOwned[msg.sender].push(Reward("Silver Coin", 0.5 ether)); 0.25 ether
+ silver must be 0.25 ether
} else {
// 1% chance to get Gold Coin (99)
- rewardsOwned[msg.sender].push(Reward("Gold Coin", 1 ether));
+ gold must be 0.5 ether
}
Impact
Discrepancy between intended rewards for boxes and real will drain the protocol and break it core invariants.
Recommendations
Remove wrong data from openBoxfunction.
Updates
Appeal created
inallhonesty 11 months ago
Submission Judgement Published Assigned finding tags:
The rewards in constructor are different from the rewards in openBox
Rewards breakdown
nSLOC
86This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.