Missing access control for `changeOwner` function
Summary
changeOwnerfunction has no access control and is callable by anyone.
Vulnerability Details
By passing a new address _newOwnerto the function anyone can change the owner of the protocol.
Impact
As per the specifications and the implementation, the owner can set the price of boxes, add new rewards, and withdraw funds. All these are key aspects of the functionality, which when made accessible by a malicious user could lead to critical issues with the protocol as changing fees, depleting the protocol of its funds, etc.
PoC
The test snippet is already in the .t.sol file. Just run forge test --mt testChangeOwner.
Tools Used
Manual Review, Foundry
Recommendations
Implement access control to the function.
Appeal created
Anyone can change owner
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.