Submission Details
Severity:
Array out-of-bounds access Revert When No Vote is Registered
Summary
If there is no valid vote, calling function selectPresident() will revert with array out-of-bounds access.
Vulnerability Details
The code on line 126 which is executed during the call to selectPresident() then _selectPresidentRecursive() assumes that there is always at least one entry on candidateList array.
address fewestVotesCandidate = candidateList[0];
If there is no vote, then candidateList is empty. Therefore, the code above tries to access an empty list which causes the revert.
Impact
The call to selectPresident() reverts.
Tools Used
Testing
Recommendations
Add a code to handle if there is no candidate to prevent the revert.
Rewards breakdown
nSLOC
140This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.