Submission Details
Severity:
TYPEHASH has Incorrect Variable Type
Summary
The TYPEHASH variable (RankedChoice.sol::Line 23) should not be a uint[] but an address[]. In this contract, a vote ranks a list of candidates.
Vulnerability Details
bytes32 public constant TYPEHASH = keccak256("rankCandidates(uint256[])"); //@audit - TYPEHASH Missing Address Member (candidate).
Impact
The current implementation prevents a signer from ranking candidates by address. It only allows a order ranking of uints without any candidate corresponding to each ranking.
Tools Used
Manual Review
Recommendations
The TYPEHASH variable should be:
bytes32 public constant TYPEHASH = keccak256("rankCandidates(address[])");
It should not be:
bytes32 public constant TYPEHASH = keccak256("rankCandidates(uint256[])");
The address[] allows the signer to rank specific candidates.
Updates
Lead Judging Commences
inallhonesty about 1 year ago
Submission Judgement Published Assigned finding tags:
Typehash hashes the wrong function input.
Rewards breakdown
nSLOC
140This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.