Submission Details
Severity:
rankCandidatesBySig() Does Not Check if msg.sender is approved voter
Summary
rankCandidatesBySig() does not check to see if the msg.sender is a voter. This allows ineligible users to vote.
Vulnerability Details
function rankCandidatesBySig(
address[] memory orderedCandidates,
bytes memory signature
) external {
bytes32 structHash = keccak256(abi.encode(TYPEHASH, orderedCandidates));
bytes32 hash = _hashTypedDataV4(structHash);
address signer = ECDSA.recover(hash, signature);
_rankCandidates(orderedCandidates, signer);
}
Impact
Allows ineligible users vote in the election.
Tools Used
Manual Review
Recommendations
Implement a check to ensure that the caller of the function is part of the address[] private VOTERS;
Updates
Rewards breakdown
nSLOC
140This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.