President Elector
First Flight #24
Beginner FriendlyFoundry
100 EXP
View results
Previous Next
Submission Details
Severity: medium
Invalid

Hardcoded Values

0xethsol

Summary

MAX_CANDIDATESis hardcoded to 10.

Impact

//Limits flexibility and requires contract upgrades for changes.
uint256 private constant MAX_CANDIDATES = 10;

Tools Used

Manual Review

Recommendations

Make MAX_CANDIDATESconfigurable via the constructor.

uint256 private immutable i_maxCandidates;
​
constructor(address[] memory voters, uint256 maxCandidates) EIP712("RankedChoice", "1") {
require(maxCandidates > 0, "Max candidates must be greater than 0");
i_maxCandidates = maxCandidates;
}
​
Updates

Lead Judging Commences

inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Appeal created

0xethsol Submitter
11 months ago
inallhonesty Lead Judge
11 months ago
inallhonesty Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.