President Elector

First Flight #24
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: high
Invalid

H-1. Incorrect signature type hash defination breaks `RankedChoice.sol::rankCandidatesBySig`

Summary

Vulnerability Details

The EIP-712 standard, the type hash should be defined as keccak256("rankCandidates(address[])") in a struct. instead of keccak256("rankCandidates(uint256[])"). This will ensure that the signature is correctly validated.

Impact

This will cause the signature to be incorrectly validated. RankedChoice.sol::rankCandidatesBySig will not work as intented. Voters can not vote without paying gas fees which is one of the main features of the protocol.

Tools Used

Recommendations

Consider changing the type hash to keccak256("rankCandidates(address[])") in a the struct.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.