Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: low
Invalid

`_totalFeesBasisPoints()` inconsistency between `StakingPool` and `VaultControllerStrategy`

Summary

In StakingPool, _totalFeesBasisPoints() is required to be `<= 4000` whereas in VaultControllerStrategy it is required to be `<= 3000`. That's an inconsistency that has to be fixed.

Impact

There can be a max difference of 10% between the StakingPool cotnract and VaultControllerStrategy

Tools Used

Manual analysis

Recommendations

Choose a unique fee threshold and stick to it across the whole codebase

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Appeal created

0xjarix Submitter
7 months ago
inallhonesty Lead Judge
7 months ago
inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.