Submission Details
Severity:
Fee Receiver Will Not Always Receive Fee
Summary
In StakingPool::_updateStrategyRewards at the last iteration of receivers array, all of the current balance is send to the fee receiver.
if (feesPaidCount == totalFeeCount - 1) {
transferAndCallFrom(
address(this),
receivers[i][j],
balanceOf(address(this)),
"0x"
);
}
But the problem is the underlying logic will return 0, if balanceOf < 100 and the last receiver will not receive their reward.
Tools Used
Manual review
Recommendations
Consider refactoring the logic, so the last fee receiver to receive their fee.
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.