Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: high
Invalid

updateStrategyRewards() is broken as it uses rebaseController address for verifying strategy

Summary

updateStrategyRewards() is broken as it uses rebaseController address for verifying strategy

Vulnerability Details

updateStrategyRewards() checks if the strategy exists or not by calling _strategyExists(), but the problem is, it passes rebaseController address in place of strategy address

function updateStrategyRewards(uint256[] memory _strategyIdxs, bytes memory _data) external {
-> if (msg.sender != rebaseController && !_strategyExists(msg.sender))
revert SenderNotAuthorized();
_updateStrategyRewards(_strategyIdxs, _data);
}

Impact

updateStrategyRewards() will revert

Tools Used

VS code

Recommendations

Use strategy address instead of rebaseController address

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.