Liquid Staking

Summary

Vulnerability Details

Lines of impacted code:

• https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/priorityPool/PriorityPool.sol#L549

• https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/priorityPool/PriorityPool.sol#L397

• https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/priorityPool/PriorityPool.sol#L132

It is possible for the contract owner to accidentally/deliberately set a value for queueDepositMin which is greater than queueDepositMax or a value queueDepositMax which is less than queueDepositMin. If this happens then this will break many function's logic of PriorityPool contract including _depositQueuedTokens.

Impact

Incorrect value of queueDepositMin and queueDepositMax might break PriorityPool contract logic.

Tools Used

Manual

Recommendations

Add a value check, something like:
require(_queueDepositMin> 0 && _queueDepositMax > _queueDepositMin);