Liquid Staking

Summary

The isRemoved function in the contract is intended to check whether an item or entity has been removed. However, the current implementation always returns false, regardless of the actual state of the item.

Affected Code

• https://github.com/Cyfrin/2024-09-stakelink/blob/f5824f9ad67058b24a2c08494e51ddd7efdbb90b/contracts/linkStaking/base/Vault.sol#L129-L131

Impact

This will create a confusion as the function internally calling isRemoved()will always receive false boolean value.

Tools Used

Manual

Recommendations

Instead of always returning false, the contract should store the removal status of the item in a variable and update that status when an item is removed