Relevant GitHub Links

https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/lstRewardsSplitter/LSTRewardsSplitterController.sol#L75-L88

https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/lstRewardsSplitter/LSTRewardsSplitterController.sol#L92-L108

Summary

The rewardThreshold in the LSTRewardsSplitterController contract is intended to prevent frequent or minimal reward splitting. However, if not correctly enforced, it can lead to unintended behaviors or exploitations.

Vulnerability Details

In LSTRewardsSplitterController.sol, the checkUpkeep function determines if performUpkeep should be called based on reward thresholds:

The actual enforcement of rewardThreshold occurs within each splitter:

Impact

Insufficient threshold enforcement can lead to frequent, minimal distributions, increasing gas costs and user inconvenience. Attackers might manipulate or exploit thresholds to gain disproportionate rewards or disrupt the intended reward distribution schedule.

Tools Used

Manual Code Review

Recommendations

Consider enforcing rewardThreshold at the controller level to ensure consistent application across all splitters. Validate _performData validation of the encoded data in performUpkeep to prevent manipulation or unintended function executions.