Liquid Staking
Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

`_queueDepositMin` and `_queueDepositMax` in `PriorityPool::depositQueuedTokens` Function Shadows the State Variables `queueDepositMin` and `queueDepositMax`

Gladiators

Summary

_queueDepositMin and _queueDepositMax in PriorityPool::depositQueuedTokens shadow the state variables queueDepositMin and queueDepositMax.

Vulnerability Details

_queueDepositMin and _queueDepositMax in PriorityPool::depositQueuedTokens are passed without any checks against the respective state variables queueDepositMin and queueDepositMax. There may be cases where the function PriorityPool::depositQueuedTokens is called with a value of _queueDepositMin less than queueDepositMin and a value of _queueDepositMax greater than queueDepositMax.

Impact

Executing the depositQueuedTokens function with any values of _queueDepositMin and _queueDepositMax without validation.

Recommendations

Add the following check:

require(_queueDepositMin >= queueDepositMin && _queueDepositMax <= queueDepositMax);
Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.