Summary

There is a discrepancy between the documented authorization and actual implementation of pause functionality in PriorityPool.sol. While the code comments indicate that only rebaseController has pause authorization, the implementation allows distributionOracle to pause the pool.

Vulnerability Details

According to comments in the PriorityPool.sol, only rebaseController has the authorization to pause the pool

However, the pauseForUpdate function uses the onlyDistributionOracle modifier, meaning only the distribution oracle can call this function:

If the intention was truly to only allow rebaseController to pause the pool, then having distributionOracle able to pause represents an unintended privilege escalation.

Impact

The distributionOracle has unauthorized pause capabilities that weren't intended according to the documentation.

Tools Used

Manual Review

Recommendations