Submission Details
Severity:
The updateFee function can remove the last (or only) fee from the fees array
Summary
The updateFee function can remove the last (or only) fee from the fees array, resulting to an empty array.
Vulnerability Details
In the updateFee function, there's no check on the index about to be removed if it is the only index in the array before removal.
function updateFee(
uint256 _index,
address _receiver,
uint256 _feeBasisPoints
) external onlyOwner {
require(_index < fees.length, "Fee does not exist");
if (_feeBasisPoints == 0) {
fees[_index] = fees[fees.length - 1];
fees.pop();
} else {
fees[_index].receiver = _receiver;
fees[_index].basisPoints = _feeBasisPoints;
}
if (_totalFeesBasisPoints() > 10000) revert FeesExceedLimit();
}
Impact
The function removes the last fee, leaving the fees array empty.
Tools Used
Manual review
Recommendations
The function should maintain at least one fee in the array or handle the case of an empty fee array
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020
USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.