Submission Details
Severity:
There's no explicit check for zero amount in the `StakingPool::burn` function.
Relevant GitHub Links
Summary
The StakingPool::burn function can be called with a zero amount.
Vulnerability Details
When burning the senders liquid staking tokens with the StakingPool::burn function, no restriction was be made about the zero amount so the Burn event will still be emitted, even if no actual burning occurred, which creates confusion and consumes gas unnecessarily:
function burn(uint256 _amount) external {
// @audit missing prevent zero-value transfers
_burn(msg.sender, _amount);
emit Burn(msg.sender, _amount);
}
Impact
- Gas Usage: The function will still consume gas even for zero burns.
- Event Emission: Emitting an event for a zero burn might be unnecessary and could potentially lead to confusion in off-chain systems monitoring these events.
Tools Used
Manual analysis.
Recommendations
function burn(uint256 _amount) external {
+ require(_amount > 0, "Burn amount must be greater than zero");
_burn(msg.sender, _amount);
emit Burn(msg.sender, _amount);
}
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.