Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Redundant depositLimit check in OperatorStakingPool

Summary

Redundant depositLimit check in OperatorStakingPool

Vulnerability Details

The OperatorStakingPool already ensures that the operator deposits didn't exceed the depositLimitin the onTokenTransferfunction which is the entry point for the token to enter the contract. Yet, the getOperatorPrincipalview function need to check this again that the returned value does not exceed the depositLimit.

Impact

The code became more complex than it should have been.

Tools Used

Manual Review

Recommendations

Just return the balance in the getOperatorPrincipalview function directly without the need to check the depositLimit

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.