Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: medium
Invalid

Regulation of depositMax to avoid slippage

Summary

In the PriorityPool.sol contract, specifically at line 541 in the _depositQueuedTokens function, there is a lack of deposit limits per user. While the function checks for a minimum deposit amount, it does not enforce a maximum deposit limit for individual users. This could allow a single user with a large amount of tokens to dominate the deposit queue and exert undue influence on the pool.

Impact

  • Risk of Pool Domination: A user with a disproportionately large number of tokens could queue or deposit an excessive amount of tokens, effectively dominating the pool. This would undermine the fairness and decentralized nature of the system, where ideally each participant should have a proportional influence based on their contribution.

  • Centralization Risk: The absence of a deposit cap creates the potential for centralization, where a few users could hold a majority share in the pool, reducing the incentives and opportunities for smaller participants.

  • Potential for Manipulation: Without per-user limits, large deposits could be strategically used to manipulate the behavior of the pool, especially in the
    context of governance or profit distribution, thereby harming the smaller users or even the system's sustainability.

Recommendations

  • Implement Per-User Deposit Limits: Introduce a cap on the maximum amount of tokens a single user can queue or deposit, preventing any one user from dominating the pool. The limit could be a fixed amount or a percentage of the total pool size, depending on the desired level of decentralization.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!