Submission Details
Severity:
upgradeVaults could be improved to save gas
Summary
The functionupgradeVaultsin VaultControllerStrategy.sol upgrade all vaults regardless if the vault has been removed or not causing waste of gas as it is unnecessary to upgrade removed vaults.
Vulnerability Details
The function upgradeVaultsin VaultControllerStrategy.sol upgrade all vaults regardless if the vault has been removed or not.
Impact
upgradeVaultsfunction uses more gas to execute the function which could be saved if only the function skip removed vaults.
Tools Used
Manual review
Recommendations
Skip removed vaults in upgradeVaultsfunction.
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.