Submission Details
Severity:
should depositLiquidity() in StakingPool.sol#addStrategy()
Summary
should depositLiquidity() in StakingPool.sol#addStrategy()
Vulnerability Details
when deposit(), if some Strategies reached limits, there will be some tokens remain under address(this), those tokens should be deposited to available Strategies as soon as possible.
Besides, when delete strategy, some tokens will be withdrawed to address(this).
So, when new strategy added, those tokens under address(this) should be deposited immediately.
Impact
tokens are not deposited to strategies immediately.
Tools Used
mannually reviwed
Recommendations
function addStrategy(address _strategy) external onlyOwner {
require(!_strategyExists(_strategy), "Strategy already exists");
token.safeApprove(_strategy, type(uint256).max);
strategies.push(_strategy);
depositLiquidity();
}
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.