Liquid Staking

Summary

The functions initialize/setQueueDepositParams set minimum and maximum deposit values, but lacks checks on the relationship between these two parameters.

Vulnerability Details

The absence of validation ensures that queueDepositMin is less than or equal to queueDepositMax could lead to logical errors in the contract.

Location

https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/priorityPool/PriorityPool.sol#L119-L136
https://github.com/Cyfrin/2024-09-stakelink/blob/main/contracts/core/priorityPool/PriorityPool.sol#L549-L556

Impact

If queueDepositMin is set greater than queueDepositMax, it could cause issues with deposit logic, potentially allowing for unintended behavior or exploitation.

Recommendations

Add a validation check within the function to ensure that _queueDepositMin is less than or equal to _queueDepositMax before updating the state variables.