Liquid Staking
Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing minimum and maximum setQueueDepositParams Checks

miquinho

Vulnerability Details

The Owner may end up making a mistake and putting the minimum value as the maximum value and the maximum value as the minimum value.

function setQueueDepositParams(
uint128 _queueDepositMin,
uint128 _queueDepositMax
) external onlyOwner {
// @audit-issue [L-01] Missing minimum and maximum setQueueDepositParams Checks
queueDepositMin = _queueDepositMin;
queueDepositMax = _queueDepositMax;
emit SetQueueDepositParams(_queueDepositMin, _queueDepositMax);
}

Impact

when o owner define value minimum as value maximum it may affects the contract logic and user experience

Tools Used

Visual Studio Code + Manual Review

Recommendations

Adding one checks

require(_queueDepositMin <=_queueDepositMax)
Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.