Submission Details
Severity:
Optimization of gas consumption in `WithdrawalPool::getWithdrawalIdsByOwner`
Summary
This function takes the length of activeWithdrawals in the loop, which causes more gas consumption
for (uint256 i = 0; i < activeWithdrawals.length; ++i) {
uint256 withdrawalId = queuedWithdrawalsByAccount[_account][i];
Withdrawal memory withdrawal = queuedWithdrawals[withdrawalId];
if (withdrawal.sharesRemaining != 0 || withdrawal.partiallyWithdrawableAmount != 0) {
activeWithdrawals[i] = withdrawalId;
totalActiveWithdrawals++;
}
}
Vulnerability Details
More gas consumption
Impact
Tools Used
Recommendations
To use less gas, the length of activeWithdrawals can be extended
uint256 totalActiveWithdrawals;
+ uint256 lenghthOfActiveWithdrawals=activeWithdrawals.length;
for (uint256 i = 0; i <lenghthOfActiveWithdrawals ; ++i) {
uint256 withdrawalId = queuedWithdrawalsByAccount[_account][i];
Withdrawal memory withdrawal = queuedWithdrawals[withdrawalId];
if (withdrawal.sharesRemaining != 0 || withdrawal.partiallyWithdrawableAmount != 0) {
activeWithdrawals[i] = withdrawalId;
totalActiveWithdrawals++;
}
}
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.