Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: low
Invalid

Missing Event Emission in `setDepositLimit` in `OperatorStakingPool`

Summary

The setDepositLimit function updates the maximum deposit limit per operator but does not emit an event to log this change.

Vulnerability Details

The setDepositLimit function allows the contract owner to modify the depositLimit variable. However, it fails to emit an event indicating that the deposit limit has been changed. This omission means that external observers (such as off-chain services) will not be notified of the change, which can lead to inconsistencies and difficulties in tracking state changes.

Impact

The absence of an event can hinder the ability to monitor contract changes effectively. It reduces the transparency of contract operations and may complicate debugging and auditing processes. Furthermore, it could potentially lead to trust issues with users who expect event logs for significant changes.

Tools Used

  • Slither

Recommendations

Modify the setDepositLimit function to include an event emission after updating the depositLimit. For example:

event DepositLimitSet(uint256 newDepositLimit);
function setDepositLimit(uint256 _depositLimit) external onlyOwner {
depositLimit = _depositLimit;
emit DepositLimitSet(_depositLimit);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 8 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.