Submission Details
Severity:
Missing check of total fees < 10000 when setting in constructor of LSTRewardsSplitter.sol
Summary
The fees array is set in the constructor of LSTRewardsSplitter.sol. There is no validation of _totalFeesBasisPoints() < 10000.
Vulnerability Details
The fees can be set > 100% initially.
Impact
Because of missing validation in the constructor the fees can be set > 10000 which will lead to _splitRewards() taking amount out of users principalDeposits.
Tools Used
Vs Code
Recommendations
Add the same check of _totalFeesBasisPoints() < 10000 as used in addFee() and updateFee() methods.
constructor(address _lst, Fee[] memory _fees, address _owner) {
controller = ILSTRewardsSplitterController(msg.sender);
lst = IERC677(_lst);
for (uint256 i = 0; i < _fees.length; ++i) {
fees.push(_fees[i]);
}
+++ if (_totalFeesBasisPoints() > 10000) revert FeesExceedLimit();
_transferOwnership(_owner);
}
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.