Submission Details
Severity:
Miss Handling of Zero Deposite
Vulnerability Details
The LSTRewardsSplitter::Deposit does not have the right check that can stop the deposit of Zero amount into the contract, this can lead to unnecessary state changes or other unintended behaviors.
Impact
function deposit(uint256 _amount) external onlyController {
lst.safeTransferFrom(msg.sender, address(this), _amount);
principalDeposits += _amount;
emit Deposit(_amount);
}
The controller can mistakenly deposit Zero amount into the contract and this can lead to unnecessary state or other unintentioned behaviors
Tools Used
manual review
Recommendations
Add a check to prevent zero deposits, ensuring that the _amount is greater than zero.
function deposit(uint256 _amount) external onlyController {
// Prevent zero deposit
++ if (_amount == 0) revert InvalidDepositAmount(); // Custom error or require statement
lst.safeTransferFrom(msg.sender, address(this), _amount);
principalDeposits += _amount;
emit Deposit(_amount);
}
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.