Submission Details
Severity:
Unhadled decoding error in performUpkeep function
Summary
Unhadled decoding error in performUpkeep function.
Vulnerability Details
In the performUpkeep function, there's an attempt to decode the _performData parameter using abi.decode(_performData, (bool[])). If this decoding fails due to improperly formatted input data, the function will revert without providing a clear error message or allowing for graceful error handling.
*/
function performUpkeep(bytes calldata _performData) external {
bool[] memory splittersToCall = abi.decode(_performData, (bool[]));
bool splitterCalled;
for (uint256 i = 0; i < splittersToCall.length; ++i) {
if (splittersToCall[i] == true) {
splitters[accounts[i]].performUpkeep("");
splitterCalled = true;
}
}
if (splitterCalled == false) {
revert InvalidPerformData();
}
}
Impact
The function will revert without providing a clear error.
Tools Used
Manual review
Recommendations
Handle decoding error.
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020
USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.