Liquid Staking

Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Submission Details
Severity: medium
Invalid

The function lack proper access control modifiers, allowing any external user to call them.

Summary

The function lack proper access control modifiers, allowing any external user to call them. This is the root issue

Vulnerability Details

/**
* @notice Deposits queued tokens and/or unused tokens sitting in staking pool
* @dev allows bypassing of the stored deposit limits
* @param _queueDepositMin min amount of tokens required for deposit into staking pool strategies
* @param _queueDepositMax max amount of tokens that can be deposited into staking pool strategies at once
* @param _data list of deposit data passed to staking pool strategies
*/
function depositQueuedTokens(
uint256 _queueDepositMin,
uint256 _queueDepositMax,
bytes[] calldata _data
) external {
_depositQueuedTokens(_queueDepositMin, _queueDepositMax, _data);
}

The function lack proper access control modifiers, allowing any external user to call them. depositQueuedTokens is marked as external without any access restrictions.

Malicious actors could manipulate deposits, trigger undesired operations, or disrupt the pool's functionality. Unrestricted access to critical functions could lead to fund mismanagement or exploitation.

Bypassing stored deposit limits could lead to inconsistencies between the contract's stated rules and its actual behavior, potentially breaking assumptions made by other parts of the system or by users. An attacker could potentially pass a very large array, causing the transaction to hit the block gas limit and fail.

Impact

DOS is one of the possible attacks for this function.

Tools Used

Manual Review

Recommendations

Apply appropriate access control modifiers (onlyOwner, onlyDistributionOracle, etc.) to functions that should be limited to specific roles.

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Lack of quality

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.