Liquid Staking
Stakelink
DeFiHardhatOracle
50,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Removing fee struct instead of updating in UpdateFee function in StakingPool Contract

Gladiators

Summary

Removing fee object instead of updating in UpdateFee function in StakingPool Contract contardicts the natspec comments

Vulnerability Details

Removing fee object instead of updating in UpdateFee function in StakingPool Contract contardicts the natspec comments

https://github.com/Cyfrin/2024-09-stakelink/blob/f5824f9ad67058b24a2c08494e51ddd7efdbb90b/contracts/core/StakingPool.sol#L358

Tools Used

Manual Review

Recommendations

just update fee to 0 or introduce new function to remove the fee object

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.