Submission Details
Severity:
Redundant updation of withdrawalPool while updating with previous previous withdrawalPool address in setWithdrawalPool
Summary:
calling setWithdrawalPool with the old withdrawalPool address is redundant
Vulnerability Details
setting the withdrawal pool in setWithdrawalPool with the same old withdrawalPool address makes redundant
Tools used:
Manual Inspection
Recommendation:
Add this below check in setWithdrawalPool
function setWithdrawalPool(address _withdrawalPool) external onlyOwner {
require(_withdrawalPool == withdrawalPool, "can't update with same withdrawalPool address");
...
}
code snippet
https://github.com/Cyfrin/2024-09-stakelink/blob/f5824f9ad67058b24a2c08494e51ddd7efdbb90b/contracts/core/priorityPool/PriorityPool.sol#L579
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.