Submission Details
Severity:
updateStrategyRewards() is broken
Summary
updateStrategyRewards() is broken
Vulnerability Details
updateStrategyRewards() distributes rewards/fees based on balance changes in strategies since the last update. It is only called by rebaseController & strategy should exist. But the problem is while verifying strategy, instead of passing strategy address, it passes rebaseController address ie msg.sender.
function updateStrategyRewards(uint256[] memory _strategyIdxs, bytes memory _data) external {
@> if (msg.sender != rebaseController && !_strategyExists(msg.sender)) {
revert SenderNotAuthorized();
}
_updateStrategyRewards(_strategyIdxs, _data);
}
Impact
updateStrategyRewards() will be DoS
Tools Used
Manual Review
Recommendations
Pass strategy address to _strategyExists(), instead of passing rebaseController address
Prize pool breakdown
Total prize
50,000 USDC
nSLOC
2,53020 USDC / LOC
42,000 USDC
4,250 USDC
3,750 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.