There is an issue with assignment to highest_bid
in function start()
.
The code on line 89 indicates a value assignment to variable highest_bid
despite there is no asset transfer to the contract.
This code will make the code on line 149 useless.
However, if highest_bid
is not assigned with starting_bid
, then line 149 potentially causes the auctioned NFT to be locked if there is no bid.
The asset accounting becomes incorrect.
Manual review.
Consider refactoring the code on line 89 and 149 to prevent the issues mentioned.
If there are no placed bids in the auction, the `end` function will always revert. The owner can not receive back the nft ant it will be locked in the contract.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.