Starknet Auction

First Flight #26
Beginner FriendlyNFT
100 EXP
View results
Submission Details
Severity: medium
Valid

[EVMN] Potential Incorrect Logic In `start()`

Summary

There is an issue with assignment to highest_bid in function start().

Vulnerability Details

The code on line 89 indicates a value assignment to variable highest_bid despite there is no asset transfer to the contract.
This code will make the code on line 149 useless.

However, if highest_bid is not assigned with starting_bid, then line 149 potentially causes the auctioned NFT to be locked if there is no bid.

Impact

The asset accounting becomes incorrect.

Tools Used

Manual review.

Recommendations

Consider refactoring the code on line 89 and 149 to prevent the issues mentioned.

Updates

Lead Judging Commences

bube Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

The NFT will be locked if there are no bids

If there are no placed bids in the auction, the `end` function will always revert. The owner can not receive back the nft ant it will be locked in the contract.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.