Submission Details
Severity:
users can register without sending tokens
Summary
the registration of a user is based on tokens being transferred to the contract using transferFrom, if the transfer fails silently, the registration amount for the user will still be increased
Vulnerability Details
user calls register function and these two lines are run, if transferFrom fails without reverting, the amount of the registration will still be incremented
token.transferFrom(msg.sender, address(this), amount);
// register the user
registrations[msg.sender][kind] = amount;
Impact
Users can basically steal token from the contract if the transfers during registration fail silently
Tools Used
Manual review
Recommendations
`SafeTransferFrom` covers a wider range of token behaviors and should be used here
Updates
Lead Judging Commences
inallhonesty 12 months ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
[KNOWN] - Low-35 Unsafe use of transfer()/transferFrom() with IERC20
Prize pool breakdown
Total prize
21,000 USDC
nSLOC
1,03420
USDC / LOC
20,000 USDC
1,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.