Dria

Summary

Currently there is no minimum price meaning that a listing with price equal to 0 will be valid and will have no fees paid.

Vulnerability Details

In Swan::list and Swan::relist when listing/relisting a given asset there is no check whether the price is 0. This means that an asset with price equal to 0 is a valid one. However, the problem is that no fees and royalties will be paid for such a listing. In the end both the seller and the protocol are losing from such a listing.

Impact

Lost fees and royalties both for seller and for the protocol.

Tools Used

Manual Review

Recommendations

Either change the logic of fees/royalties calculation to account for such a case or revert when someone tries to list/relist an asset with price equal to 0.